You are not logged in.

Announcement

 Téléchargez la dernière version stable de GLPI      -     Et vous, que pouvez vous faire pour le projet GLPI ? :  Contribuer
 Download last stable version of GLPI                      -     What can you do for GLPI ? :  Contribute

#1 2006-07-11 20:11:09

mags
Member
From: CH
Registered: 2006-06-06
Posts: 12

uemail form field auto-fill -- helpdesk.public.php vs. helpdesk.php

filling out a new ticket, the "helpdesk" interface correctly auto-fill the user's email address from the profile.
but the "command center" interface does not, even though the user does have an email address in the profile.

I am not sure if this is a bug, or perhaps just some profile permission/rights setting for "command center" that I have set wrong?
I do try to find the UI generator for this form but not positive where it is.

(I do try to search the bugtrack and the french forums for several days, but my french is very bad and google transl. not always helpful...)

many thanks for any help

ps --
I guess that perhaps this block in inc/tracking.class.php prepareInputForAdd() sets it automatically even if the form field is blank?

        if (isset($input["emailupdates"])&&$input["emailupdates"]=="yes"&&empty($input["uemail"])){
            $user=new User();
            $user->getFromDB($input["author"]);
            $input["uemail"]=$user->fields["email"];
        }

but still nice if the helpdesk.php form field uemail is filled in, it confuse the users less!..

Last edited by mags (2006-07-11 20:12:28)


non toxique (si utilisé comme prescrit)

Offline

#2 2006-07-11 21:02:26

mags
Member
From: CH
Registered: 2006-06-06
Posts: 12

Re: uemail form field auto-fill -- helpdesk.public.php vs. helpdesk.php

EDIT: removed ugly fix, this is slightly better I think:

https://dev.indepnet.net:8080/glpi/ticket/610

/EDIT

Last edited by mags (2006-07-12 18:15:25)


non toxique (si utilisé comme prescrit)

Offline

#3 2006-07-22 18:22:53

MoYo
GLPI - Lead
From: Poitiers
Registered: 2004-09-13
Posts: 14,513
Website

Re: uemail form field auto-fill -- helpdesk.public.php vs. helpdesk.php

How to enter a free mail with your fix ???

I will try to make a more user-friendly system.


MoYo - Julien Dombre - Association INDEPNET
Contribute to GLPI :    Support     Contribute     References     Freshmeat

Offline

#4 2006-07-24 17:00:46

mags
Member
From: CH
Registered: 2006-06-06
Posts: 12

Re: uemail form field auto-fill -- helpdesk.public.php vs. helpdesk.php

hi MoYo

apologies but I'm not sure I understand what you mean 'enter a free mail' ?


non toxique (si utilisé comme prescrit)

Offline

#5 2006-07-24 17:26:15

JMD
GLPI - Lead
Registered: 2004-09-13
Posts: 9,180
Website

Re: uemail form field auto-fill -- helpdesk.public.php vs. helpdesk.php

Moyo means enter another email if you want.


JMD / Jean-Mathieu Doléans - Glpi-project.org - Association Indepnet
Apportez votre pierre au  projet GLPI   : Soutenir

Offline

#6 2006-07-24 18:45:24

mags
Member
From: CH
Registered: 2006-06-06
Posts: 12

Re: uemail form field auto-fill -- helpdesk.public.php vs. helpdesk.php

ah ok got it. that's what I thought but wasn't quite sure.

but the field remains editable, the user could enter a different email. no?


non toxique (si utilisé comme prescrit)

Offline

#7 2006-07-24 19:29:22

MoYo
GLPI - Lead
From: Poitiers
Registered: 2004-09-13
Posts: 14,513
Website

Re: uemail form field auto-fill -- helpdesk.public.php vs. helpdesk.php

Oups sorry I do not read correctly your patch.

In fact there is no problem of uemail.
If you let it blank, the uemail is automatically replace by the author email.


MoYo - Julien Dombre - Association INDEPNET
Contribute to GLPI :    Support     Contribute     References     Freshmeat

Offline

#8 2006-07-24 21:07:41

mags
Member
From: CH
Registered: 2006-06-06
Posts: 12

Re: uemail form field auto-fill -- helpdesk.public.php vs. helpdesk.php

If you let it blank, the uemail is automatically replace by the author email.

hi Moyo

after looking at code I realized that, thank you.

but for some (many!) users it is confusing/annoying that the field is blank, and they will spend time typing in their email address. and complain that they must type in their email every time (yes even after they are told/shown they needn't type the email, they will still do it and complain!)

it's not such a big deal, I don't mind to locally patch glpi, if others don't think this patch should be included. it's cool. ^_^

in any case: my thanks again to Moyo & JMD & rest of glpi devs, for glpi! it is making my job a lot easier!


non toxique (si utilisé comme prescrit)

Offline

#9 2006-07-24 23:33:57

MoYo
GLPI - Lead
From: Poitiers
Registered: 2004-09-13
Posts: 14,513
Website

Re: uemail form field auto-fill -- helpdesk.public.php vs. helpdesk.php

interesting thing include in the SVN smile


MoYo - Julien Dombre - Association INDEPNET
Contribute to GLPI :    Support     Contribute     References     Freshmeat

Offline

#10 2006-07-25 16:27:21

mags
Member
From: CH
Registered: 2006-06-06
Posts: 12

Re: uemail form field auto-fill -- helpdesk.public.php vs. helpdesk.php

nice! many thanks!!


non toxique (si utilisé comme prescrit)

Offline

Board footer

Powered by FluxBB