uemail form field auto-fill -- helpdesk.public.php vs. helpdesk.php

mags · 2006-07-11 20:11:09

filling out a new ticket, the "helpdesk" interface correctly auto-fill the user's email address from the profile.
but the "command center" interface does not, even though the user does have an email address in the profile.

I am not sure if this is a bug, or perhaps just some profile permission/rights setting for "command center" that I have set wrong?
I do try to find the UI generator for this form but not positive where it is.

(I do try to search the bugtrack and the french forums for several days, but my french is very bad and google transl. not always helpful...)

many thanks for any help

ps --
I guess that perhaps this block in inc/tracking.class.php prepareInputForAdd() sets it automatically even if the form field is blank?

        if (isset($input["emailupdates"])&&$input["emailupdates"]=="yes"&&empty($input["uemail"])){
            $user=new User();
            $user->getFromDB($input["author"]);
            $input["uemail"]=$user->fields["email"];
        }

but still nice if the helpdesk.php form field uemail is filled in, it confuse the users less!..

Last edited by mags (2006-07-11 20:12:28)

mags · 2006-07-11 21:02:26

EDIT: removed ugly fix, this is slightly better I think:

https://dev.indepnet.net:8080/glpi/ticket/610

/EDIT

Last edited by mags (2006-07-12 18:15:25)

MoYo · 2006-07-22 18:22:53

How to enter a free mail with your fix ???

I will try to make a more user-friendly system.

mags · 2006-07-24 17:00:46

hi MoYo

apologies but I'm not sure I understand what you mean 'enter a free mail' ?

JMD · 2006-07-24 17:26:15

Moyo means enter another email if you want.

mags · 2006-07-24 18:45:24

ah ok got it. that's what I thought but wasn't quite sure.

but the field remains editable, the user could enter a different email. no?

MoYo · 2006-07-24 19:29:22

Oups sorry I do not read correctly your patch.

In fact there is no problem of uemail.
If you let it blank, the uemail is automatically replace by the author email.

mags · 2006-07-24 21:07:41

If you let it blank, the uemail is automatically replace by the author email.

hi Moyo

after looking at code I realized that, thank you.

but for some (many!) users it is confusing/annoying that the field is blank, and they will spend time typing in their email address. and complain that they must type in their email every time (yes even after they are told/shown they needn't type the email, they will still do it and complain!)

it's not such a big deal, I don't mind to locally patch glpi, if others don't think this patch should be included. it's cool. ^_^

in any case: my thanks again to Moyo & JMD & rest of glpi devs, for glpi! it is making my job a lot easier!

MoYo · 2006-07-24 23:33:57

interesting thing include in the SVN

mags · 2006-07-25 16:27:21

nice! many thanks!!

Forum GLPI-Project

Announcement

#1 2006-07-11 20:11:09

uemail form field auto-fill -- helpdesk.public.php vs. helpdesk.php

#2 2006-07-11 21:02:26

Re: uemail form field auto-fill -- helpdesk.public.php vs. helpdesk.php

#3 2006-07-22 18:22:53

Re: uemail form field auto-fill -- helpdesk.public.php vs. helpdesk.php

#4 2006-07-24 17:00:46

Re: uemail form field auto-fill -- helpdesk.public.php vs. helpdesk.php

#5 2006-07-24 17:26:15

Re: uemail form field auto-fill -- helpdesk.public.php vs. helpdesk.php

#6 2006-07-24 18:45:24

Re: uemail form field auto-fill -- helpdesk.public.php vs. helpdesk.php

#7 2006-07-24 19:29:22

Re: uemail form field auto-fill -- helpdesk.public.php vs. helpdesk.php

#8 2006-07-24 21:07:41

Re: uemail form field auto-fill -- helpdesk.public.php vs. helpdesk.php

#9 2006-07-24 23:33:57

Re: uemail form field auto-fill -- helpdesk.public.php vs. helpdesk.php

#10 2006-07-25 16:27:21

Re: uemail form field auto-fill -- helpdesk.public.php vs. helpdesk.php

Board footer