Login after failure doesn't redirect any more

ertai · 2009-10-08 21:46:07

When you login after a failure to login the login-page pushes you to the default startpage, even when it should be redirecting. I have changed code to fix this but i don't know where I can post it. Can anyone tell me this?

MoYo · 2009-10-08 21:46:57

http://www.glpi-project.org/forum/viewt … p?id=10279

ertai · 2009-10-09 12:35:20

I verified the bug in the bugtrack. But the bug isn't there in English.. Maybe in French but I can't read French so I don't know for sure.

The GLPI's I tested are 0.72.2 and the nightly build of 08-10-2009 (Yesterday). I made clean installs of these versions and tested it. It isn't implemented in theses GLPI versions so the platforms don't matter.

I still have the code to fix it. with diffs from the nightly build of 08-10-2009. Where can I submit this code?

MoYo · 2009-10-09 14:13:08

First you do not give us all needed informations to debug.

submit the diff here. We will see.

ertai · 2009-10-09 20:59:16

login.php
218,225d217
< // Redirect management
< $REDIRECT = "";
< if (isset ($_POST['redirect'])&&strlen($_POST['redirect'])>0){
<    $REDIRECT = "?redirect=" .$_POST['redirect'];
< } else if (isset ($_GET['redirect'])&&strlen($_GET['redirect'])>0){
<    $REDIRECT = "?redirect=" .$_GET['redirect'];
< }
<
234a227,234
> // Redirect management
> $REDIRECT = "";
> if (isset ($_POST['redirect'])&&strlen($_POST['redirect'])>0){
> $REDIRECT = "?redirect=" .$_POST['redirect'];
> } else if (isset ($_GET['redirect'])&&strlen($_GET['redirect'])>0){
> $REDIRECT = "?redirect=" .$_GET['redirect'];
> }
>
246,247c246,247
<    // Logout whit noAUto to manage auto_login with errors
< echo '<b><a href="' . $CFG_GLPI["root_doc"] . '/logout.php?noAUTO=1'.str_replace("?","&",$REDIRECT).'">' . $LANG['login'][1] . '</a></b></div>';
---
> // Logout whit noAUto to manage auto_login with errors
> echo '<b><a href="' . $CFG_GLPI["root_doc"] . '/logout.php?noAUTO=1">' . $LANG['login'][1] . '</a></b></div>';

logout.php
54,64d53
< // Redirect management
< $REDIRECT = "";
< if (isset ($_POST['redirect'])&&strlen($_POST['redirect'])>0){
< $REDIRECT.= "redirect=" .$_POST['redirect'];
< } else if (isset ($_GET['redirect'])&&strlen($_GET['redirect'])>0){
< $REDIRECT.= "redirect=" .$_GET['redirect'];
< }
< if ($REDIRECT <> "") {
< $REDIRECT = ($noAUTO=="")?"?":"&";
< }
<
70c59
< glpi_header($CFG_GLPI["root_doc"]."/index.php".$noAUTO.$REDIRECT);
---
> glpi_header($CFG_GLPI["root_doc"]."/index.php".$noAUTO);

MoYo · 2009-10-13 21:05:45

Thanks for the patch.
I integrate it. You could see ticket here : https://forge.indepnet.net/issues/show/1864

I close

Forum GLPI-Project

Announcement

#1 2009-10-08 21:46:07

Login after failure doesn't redirect any more

#2 2009-10-08 21:46:57

Re: Login after failure doesn't redirect any more

#3 2009-10-09 12:35:20

Re: Login after failure doesn't redirect any more

#4 2009-10-09 14:13:08

Re: Login after failure doesn't redirect any more

#5 2009-10-09 20:59:16

Re: Login after failure doesn't redirect any more

#6 2009-10-13 21:05:45

Re: Login after failure doesn't redirect any more

Board footer