Plugin: Financial Report (BUG)

timmix · 2008-07-08 07:55:21

Hello and good morning,

we use the Treeview Plugin which works best if the "Finacial Report" Plugin is also installed. And we have found a bug in the plugin: The rows between the header and the sumrow (rows of items) are shiftet by one column after column two. See the image afterwards.

I've dived the source code of the plugin "Financial report" fore some houres and put some echo() in the code, but can't frap the point where that bug have its cavern - however, I'm not that PHP-Guru I wanted to be some years ago.

So, if there anybody out there with more knowledge about PHP who is willing to fix that cosmetic bug? Yes, and I'll be going to send a small box of marchpane from my hometown to the person who fix that bug (marchpane). ;-)

Thank you.
Timm

tsmr · 2008-07-08 09:09:36

And if you adding a type in the detail of your computer ?

timmix · 2008-07-08 12:32:45

Hi,

the fourth column in evere itemsrow (not tab-heading-row or sumrow) are the types of an item, and must be normaly the third column (thats why there are these funny arrows). :-)

If you see the costs of any item in the last column, you can see that the values drops out of the table.

If it helps, the PDF-Output has also the same problem.

--
Timm

Last edited by timmix (2008-07-08 12:36:28)

tsmr · 2008-07-08 13:11:40

could you try with glpi 0.71 and this freport version ?

https://dev.indepnet.net/tarballs-plugi … ort.tar.gz

timmix · 2008-07-08 22:41:32

tsmr,

thank you for your time, but it doesn't matter which version of GLPI I use, the problem still exists. I've tried the 0.71RC3 and the daily tarball. The productionserver runs 0.70

I'm not the only one with that problem, see: http://glpi-project.org/forum/viewtopic.php?id=10148

Thank you,
Timm

tsmr · 2008-07-08 23:08:30

I don't have developed this plugin so perharps i correct this bug for the next version. So it's important to test it, no ?

So you have tried the 0.71RC3 and the daily tarball and ? the same problem ?

timmix · 2008-07-09 09:15:08

Thanks again tsmr,

yes I've tried the daily tarball and the 0.71RC3 and the problem still exists in both versions of GLPI.

Take a look:

--
Timm

Last edited by timmix (2008-07-09 09:15:21)

timmix · 2008-07-15 20:51:26

Hi tsmr,

I've searched the code for some houres and found a solution, but I think it's dirty:

In the file: $GLPI_ROOT/plugins/freport/inc/plugin_freport.functions_search.php

near line 950 I added a SKIPPING of the counter j$:

// Print other toview items
for ($j=1;$j<$toview_count;$j++){

    // *******************************************************************************
    if ($j==2) $j=3; //DIRTY! Skip second in PHP-List and third element in HTTP-Column
    // *******************************************************************************

    /**************************************************** PLUGIN_FREPORT (BEGIN)[--snip--]
    // Get item's value
     if($SEARCH_OPTION[$type][$toview[$j]]['name'] == $PLUGIN_FREPORT_TO_VIEW[11[--snip--]
             $plugin_freport_val += giveItem($type,$SEARCH_OPTION[$type][$toview[--snip--]
    /**************************************************** PLUGIN_FREPORT (END) *[--snip--]
    echo displaySearchItem($output_type,giveItem($type,$SEARCH_OPTION[$type][   [--snip--]
}

I don't know enough about PHP or programming plugins for GLPI, but now the report is exactly it must looks like, as you can see in the following picture (the green lines are for confidential reasons).

I can't figure out, why the output of "freport" has 12 columns in the heading of the table and 13 colums in every row of items (see pictures in my posts before) - but now it works and I want to ask you, if you can fix this bug in a featur release?

Thank you,
Timm

Last edited by timmix (2008-07-15 20:53:19)

tsmr · 2008-07-15 21:27:38

Can you try this ?

https://dev.indepnet.net/plugins/changeset/6856

geesus · 2008-07-16 15:22:43

timmix solution works fine.

tsmr wrote:

https://dev.indepnet.net/plugins/changeset/6856

I have the same problem but this doesnt work in my case.

The empty column is the accounting inventory number, so i added the missing column (quick and dirty solution from a non programmer) in plugin_freport.constant.php

$PLUGIN_FREPORT_TO_VIEW[0] = $LANG["common"][16]; // Name
$PLUGIN_FREPORT_TO_VIEW[1] = $LANG["common"][20]; // Inventory number
$PLUGIN_FREPORT_TO_VIEW[2] = $LANG["financial"][20]; // Inventarnummer Buchhaltung
$PLUGIN_FREPORT_TO_VIEW[3] = $LANG["common"][17]; // Type
$PLUGIN_FREPORT_TO_VIEW[4] = $LANG["common"][5]; // Manufacturer
$PLUGIN_FREPORT_TO_VIEW[5] = $LANG["common"][22]; // Model
$PLUGIN_FREPORT_TO_VIEW[6] = $LANG["state"][0]; // State
$PLUGIN_FREPORT_TO_VIEW[7] = $LANG["common"][15]; // Location
$PLUGIN_FREPORT_TO_VIEW[8] = $LANG["financial"][18]; // Order number
$PLUGIN_FREPORT_TO_VIEW[9] = $LANG["financial"][14]; // Day of purchase
$PLUGIN_FREPORT_TO_VIEW[10] = $LANG["financial"][82]; // Invoice Number
$PLUGIN_FREPORT_TO_VIEW[11] = $LANG["financial"][26]; // Supplier
$PLUGIN_FREPORT_TO_VIEW[12] = $LANG["financial"][21]; // value

timmix · 2008-07-17 10:07:51

tsmr wrote:

Can you try this ?
https://dev.indepnet.net/plugins/changeset/6856

Also, it does not work here.

--
Timm

timmix · 2008-07-17 10:13:26

geesus wrote:

The empty column is the accounting inventory number, so i added the missing column (quick and dirty solution from a non programmer) in plugin_freport.constant.php

$PLUGIN_FREPORT_TO_VIEW[0] = $LANG["common"][16]; // Name
$PLUGIN_FREPORT_TO_VIEW[1] = $LANG["common"][20]; // Inventory number
$PLUGIN_FREPORT_TO_VIEW[2] = $LANG["financial"][20]; // Inventarnummer Buchhaltung
$PLUGIN_FREPORT_TO_VIEW[3] = $LANG["common"][17]; // Type
$PLUGIN_FREPORT_TO_VIEW[4] = $LANG["common"][5]; // Manufacturer
$PLUGIN_FREPORT_TO_VIEW[5] = $LANG["common"][22]; // Model
$PLUGIN_FREPORT_TO_VIEW[6] = $LANG["state"][0]; // State
$PLUGIN_FREPORT_TO_VIEW[7] = $LANG["common"][15]; // Location
$PLUGIN_FREPORT_TO_VIEW[8] = $LANG["financial"][18]; // Order number
$PLUGIN_FREPORT_TO_VIEW[9] = $LANG["financial"][14]; // Day of purchase
$PLUGIN_FREPORT_TO_VIEW[10] = $LANG["financial"][82]; // Invoice Number
$PLUGIN_FREPORT_TO_VIEW[11] = $LANG["financial"][26]; // Supplier
$PLUGIN_FREPORT_TO_VIEW[12] = $LANG["financial"][21]; // value

Hi geesus,

in a first try it doesn't work here, getting out a SQL error - but it looks like the right way. It seems to look like, that in the table heading is one item missing (yes and maybe it's the accounting inventory number), or in the row of every item is one <td></td> too much. I will take look at the weekend.

Thank you.
--
Timm

user · 2009-03-16 18:02:33

Je voulais savoir si il ya un module ou un plugin qui me permet de faire le comptage d’impression sur mes imprimantes partagées

poste qui imprime
nb d'impression
sur quel poste
qui a imprime
nom du document
nb de page
Transparence
pour utilisation monoposte
rapport

Forum GLPI-Project

Announcement

#1 2008-07-08 07:55:21

Plugin: Financial Report (BUG)

#2 2008-07-08 09:09:36

Re: Plugin: Financial Report (BUG)

#3 2008-07-08 12:32:45

Re: Plugin: Financial Report (BUG)

#4 2008-07-08 13:11:40

Re: Plugin: Financial Report (BUG)

#5 2008-07-08 22:41:32

Re: Plugin: Financial Report (BUG)

#6 2008-07-08 23:08:30

Re: Plugin: Financial Report (BUG)

#7 2008-07-09 09:15:08

Re: Plugin: Financial Report (BUG)

#8 2008-07-15 20:51:26

Re: Plugin: Financial Report (BUG)

#9 2008-07-15 21:27:38

Re: Plugin: Financial Report (BUG)

#10 2008-07-16 15:22:43

Re: Plugin: Financial Report (BUG)

#11 2008-07-17 10:07:51

Re: Plugin: Financial Report (BUG)

#12 2008-07-17 10:13:26

Re: Plugin: Financial Report (BUG)

#13 2009-03-16 18:02:33

Re: Plugin: Financial Report (BUG)

Board footer