Mentions not creating notifications on long followups

Gibraltar · 2023-07-21 14:50:41

Hi,

Is there any known limitation on creating notifications when a user is mentioned?
We have the notifications for user mentioned configured and working, but today on a specific ticket and a regular followup (no template) the notification was not created (didn't show in the queue).

The only diference I can see is that the followup was somewhat big (over 900 characters). I've tested adding another followup on the same ticket just to mention a user and this worked. Tried again adding a new followup with the original text (900 characters) with the mentions and the notification is not generated.

Could this be a bug or am I missing something else?

Thank you.

GLPI 10.0.7

Last edited by Gibraltar (2023-07-21 15:09:15)

cconard96 · 2023-07-26 03:45:27

I am not aware of any content length limitation. Please check the GLPI logs (files/_log) to see if there are any entries being added when you try to create the followup.

Gibraltar · 2023-07-26 12:41:05

Hi cconard96,

Thank you for your feedback.
I've checked the logs and nothing obvious comes up. I can see in mail.log that my first mention (short followup) was created and sent, but the second mention (long followup) was not created. the notification.log seems related to browser notification, so no relation to issue. php-errors.log does not have anything usefull also.

Seems like the notification for mentioning a user on a long followup is not created at all:
views

Can anyone be so kind as to test adding the bellow followup while mentioning themselves and see if you get an email (user mention notification must be enabled):

3rd test long followup mention.

What is Lorem Ipsum?
Lorem Ipsum is simply dummy text of the printing and typesetting industry.
Lorem Ipsum has been the industry's standard dummy text ever since the 1500s, when an unknown printer took a galley of type and scrambled it to make a type specimen book.
It has survived not only five centuries, but also the leap into electronic typesetting, remaining essentially unchanged.
It was popularised in the 1960s with the release of Letraset sheets containing Lorem Ipsum passages,
and more recently with desktop publishing software like Aldus PageMaker including versions of Lorem Ipsum.

Why do we use it?
It is a long established fact that a reader will be distracted by the readable content of a page when looking at its layout.
The point of using Lorem Ipsum is that it has a more-or-less normal distribution of letters, as opposed to using 'Content here, content here',
making it look like readable English. Many desktop publishing packages and web page editors now use Lorem Ipsum as their default model text,
and a search for 'lorem ipsum' will uncover many web sites still in their infancy.
Various versions have evolved over the years, sometimes by accident, sometimes on purpose (injected humour and the like).

@your GLPI username

Thank you so much.

Last edited by Gibraltar (2023-07-26 12:42:06)

Gibraltar · 2023-08-02 12:27:37

Hi,

Just bumping this question.
Can anyone please test adding the above text in a followup while mentioning a user to see if the notification is created?

Thank you.

LaDenrée · 2023-08-02 14:13:35

GLPI 10.0.9;

create a followup mentioning myself; message = "short description" => OK my followup is in notificationqueue
create a followup mentioning myself; message = you example of long followup => KO my followup is NOT in notificationqueue
create a followup mentioning another; user message = "short description" => OK my followup is in notificationqueue

cconard96 · 2023-08-02 19:59:14

The example text causes the XML parser to fail to parse the content in order to find the user mentions. This failure is silently ignored in the GLPI code.
Error: "String could not be parsed as XML"

There is this comment above the part that silently ignores when it fails to parse the content that talks about "<" and ">" characters breaking it, but I don't think that is the cause of the failure here.

cconard96 · 2023-08-02 20:15:09

This pull request should fix the issue:
https://github.com/glpi-project/glpi/pull/15352

Gibraltar · 2023-08-03 10:41:40

Hi all,

First a big thank you to HELPER for testing. I'm glad the issue was reproduced, half way to resolve it.
Also thank you to CConard96 for addressing the issue, it's my understanding that the fix will be available in a future release, correct?

cconard96 · 2023-08-03 14:16:56

The fix should be included with 10.0.10 if it is approved and merged into the GLPI code.

LaDenrée · 2023-08-03 15:02:19

I confirm that it works with corrections made here https://github.com/glpi-project/glpi/pu … 1002fa6cba

I could add a big mention=> OK

Forum GLPI-Project

Announcement

#1 2023-07-21 14:50:41

Mentions not creating notifications on long followups

#2 2023-07-26 03:45:27

Re: Mentions not creating notifications on long followups

#3 2023-07-26 12:41:05

Re: Mentions not creating notifications on long followups

#4 2023-08-02 12:27:37

Re: Mentions not creating notifications on long followups

#5 2023-08-02 14:13:35

Re: Mentions not creating notifications on long followups

#6 2023-08-02 19:59:14

Re: Mentions not creating notifications on long followups

#7 2023-08-02 20:15:09

Re: Mentions not creating notifications on long followups

#8 2023-08-03 10:41:40

Re: Mentions not creating notifications on long followups

#9 2023-08-03 14:16:56

Re: Mentions not creating notifications on long followups

#10 2023-08-03 15:02:19

Re: Mentions not creating notifications on long followups

Board footer