[Plugin glpi-reports 1.11.1] 2 bugs

bugless · 2018-02-14 19:00:02

In the listofequipmentbylocation.php report there's this fragment:

$query = getSqlSubRequest("Computer",$loc,new Computer());
foreach($CFG_GLPI["infocom_types"] as $itemtype) {
   $obj = new $itemtype;
   if ($obj->isField('locations_id')) {
      $query.= "UNION (".getSqlSubRequest($itemtype,$loc,$obj).")";
   }
}

I noticed that getSqlSubRequest function is repeating itself *twice* for one same itemtype, Computer: first one being the very first function instance -before any UNION clause-, and the other one during the infocom_types loop that walks thorugh all itemtypes, including Computer itself again.
This seems to have no effect in the actual report displaying, but wouldn't it represent an unnecessary redundancy in the sql query?

Just in case, I made a workaround, or possible "fix":

$query = getSqlSubRequest("Computer",$loc,new Computer());
foreach($CFG_GLPI["infocom_types"] as $itemtype) {
   $obj = new $itemtype;
   if ($obj->isField('locations_id')) {
      if ($itemtype != "Computer") {
         $query.= " UNION (".getSqlSubRequest($itemtype,$loc,$obj).")";
      }
   }
}

Other bug, I noticed this very same old one http://forum.glpi-project.org/viewtopic … 47#p171747 stills there. Where exactly was it "fixed"? It is not fixed neither in current glpi release itself nor in github.

yllen · 2018-03-12 19:21:47

Tickets opened on the plugin: https://forge.glpi-project.org/issues/5554 and https://forge.glpi-project.org/issues/5555

yllen · 2018-03-12 19:29:50

Corrected.
You will have the corrected version tomorrow in the tarball: https://forge.glpi-project.org/tarballs-plugins/

yllen · 2018-03-16 18:23:38

Version 1.11.2 published this day

Forum GLPI-Project

Announcement

#1 2018-02-14 19:00:02

[Plugin glpi-reports 1.11.1] 2 bugs

#2 2018-03-12 19:21:47

Re: [Plugin glpi-reports 1.11.1] 2 bugs

#3 2018-03-12 19:29:50

Re: [Plugin glpi-reports 1.11.1] 2 bugs

#4 2018-03-16 18:23:38

Re: [Plugin glpi-reports 1.11.1] 2 bugs

Board footer