Forum GLPI-Project

frankywong87

Member

Registered: 2015-08-05

Posts: 17

Email Notification error for Reservation

Hi Dear all,

I found that there an error in Email Notification for Reservation.

When user reserve an item(computer ID = 2) (reservation item id = 5)

The email notification that user get is follow the reservation item id: 5 and the link bring the user to Computer ID = 5.
The correct link should bring user to computer ID=2 as the computer that he reserve is actually computer ID 2.

Email Notification that user get: host.com/glpi/index.php?redirect=Computer_5&noAUTO=1

Reservable  Item link: host.com/glpi/front/reservation.php?reservationitems_id=5

Actual Computer link: host.com/glpi/front/computer.form.php?id=2

Anyone know how to solve this?

frankywong87

Member

Registered: 2015-08-05

Posts: 17

Re: Email Notification error for Reservation

The correct link that user should receive in their email should be : host.com/glpi/index.php?redirect=Computer_2&noAUTO=1

frankywong87

Member

Registered: 2015-08-05

Posts: 17

Re: Email Notification error for Reservation

Pump, anyone know?

yllen

GLPI-DEV

From: Sillery (51)

Registered: 2008-01-14

Posts: 15,278

Re: Email Notification error for Reservation

Version of GLPI used?

---

CentOS 6.5 - CentOS 7.x
PHP 5.6 - PHP 7.x - MySQL 5.6  - MariaDB 10.2 + APC + oOPcache
GLPI from 0.72 to dev version
Certifiée ITIL (ITV2F, ITILF, ITILOSA)

frankywong87

Member

Registered: 2015-08-05

Posts: 17

Re: Email Notification error for Reservation

Thank you for your reply!

Latest Version GLPI 0.85.4 , just downloaded last week.

frankywong87

Member

Registered: 2015-08-05

Posts: 17

Re: Email Notification error for Reservation

Hi yllen, any update?

yllen

GLPI-DEV

From: Sillery (51)

Registered: 2008-01-14

Posts: 15,278

Re: Email Notification error for Reservation

Url corrected.
Now you have 2 URL: one for the reservation item and the second for the reserved item.
see https://github.com/glpi-project/glpi/issues/63
(you have correction for 0.85.5 bugfixes)

---

CentOS 6.5 - CentOS 7.x
PHP 5.6 - PHP 7.x - MySQL 5.6  - MariaDB 10.2 + APC + oOPcache
GLPI from 0.72 to dev version
Certifiée ITIL (ITV2F, ITILF, ITILOSA)

frankywong87

Member

Registered: 2015-08-05

Posts: 17

Re: Email Notification error for Reservation

Hi yllen,

Thank you for your real fast action.
I believe with both 2 different links, should be very useful and meaningful for email recipients.

However ##reservation.item## tag look like not working.

Here is what the email notification that i received:

[GLPI] New reservation

Writer:Wong GLPI
Associated item:Computer - computer 2

Start date: 2015-08-17 11:00
End date:2015-08-17 11:10
Comments:

LANG Reservation Item : Associated item
LANG Reservation Itemurl : URL of item reserved
LANG Reservation Item Name : Associated item
LANG Reservation URL: URL
Reservation Item: ##reservation.item##
Reservation Item URL: http://localhost:8080/glpi-master/index.php?redirect=Computer_2&noAUTO=1
Reservation Item Name: computer 2
Reservation URL: http://localhost:8080/glpi-master/index.php?redirect=ReservationItem_5&noAUTO=1

yllen

GLPI-DEV

From: Sillery (51)

Registered: 2008-01-14

Posts: 15,278

Re: Email Notification error for Reservation

I had only search for your problem: URL.
I'll look at this tag on next Friday.

---

CentOS 6.5 - CentOS 7.x
PHP 5.6 - PHP 7.x - MySQL 5.6  - MariaDB 10.2 + APC + oOPcache
GLPI from 0.72 to dev version
Certifiée ITIL (ITV2F, ITILF, ITILOSA)

frankywong87

Member

Registered: 2015-08-05

Posts: 17

Re: Email Notification error for Reservation

Ok thank you Very much yllen!

No rush, take your time~