Forum GLPI-Project

adecastro

Member

Registered: 2008-07-18

Posts: 3

"functional" error at stat.function.php

Well, the "error" i've got is this: the report that shows tickets grouped by technician (follow-ups) says that number of tickets without follow up techs are always 0. That´s wrong.

Actualy the query is wrong. It asks for technicians with no name ($value is ""), and it must ask for NULL followers. Lines 587-590.

case "technicien_followup":
    $WHERE.=" AND glpi_followups.author='$value'"; <- that`s the point
    $LEFTJOIN= "LEFT JOIN glpi_followups ON (glpi_followups.tracking = glpi_tracking.ID)";
break;

I think this will do the trick:

case "technicien_followup":
    if ($value == "") {
        $WHERE.=" AND glpi_followups.author is null";
    } else {
        $WHERE.=" AND glpi_followups.author='$value'";
    }
    $LEFTJOIN= "LEFT JOIN glpi_followups ON (glpi_followups.tracking = glpi_tracking.ID)";
break;

MoYo

GLPI - Lead

From: Poitiers

Registered: 2004-09-13

Posts: 14,513

Website

Re: "functional" error at stat.function.php

that right but followups without authors must not be displayed.
So correction is :
https://dev.indepnet.net/glpi/changeset/7088

---

MoYo - Julien Dombre - Association INDEPNET
Contribute to GLPI :    Support     Contribute     References     Freshmeat

adecastro

Member

Registered: 2008-07-18

Posts: 3

Re: "functional" error at stat.function.php

I think this is not a good solution. Actually there is not followups at all. Even more, you can get a ticket with no follow ups or no group requester or no category and so on. I think it should be better to get all of them in every report.

You can think of it as a "sanity" feature. It shows you how many tickets are "not completely filled" in every report.

MoYo

GLPI - Lead

From: Poitiers

Registered: 2004-09-13

Posts: 14,513

Website

Re: "functional" error at stat.function.php

technician (follow-ups) sayed : tickets which have followups written by a technician.
So tickets without followup or with followups without author must not be take into account.

If you have a ticket which have several followups writtent by several technicians, it will appear for all technicians. This stat give you duplicates tickets.

---

MoYo - Julien Dombre - Association INDEPNET
Contribute to GLPI :    Support     Contribute     References     Freshmeat

adecastro

Member

Registered: 2008-07-18

Posts: 3

Re: "functional" error at stat.function.php

technician (follow-ups) sayed : tickets which have followups written by a technician.
So tickets without followup or with followups without author must not be take into account.

That´s right. I saw it like a "still no work on incidence" indicator. It makes more sense as you say.

If you have a ticket which have several followups writtent by several technicians, it will appear for all technicians. This stat give you duplicates tickets.

Right again. Actually I can see at a glance who are more involved in resolution of incidences.